Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stream offset #4045

Closed
wants to merge 1 commit into from
Closed

fix stream offset #4045

wants to merge 1 commit into from

Conversation

shuax
Copy link
Contributor

@shuax shuax commented May 31, 2023

read is not bytes

rom1v pushed a commit that referenced this pull request May 31, 2023
@shuax @rom1v
Fix stream offset on audio buffer underflow
b2d8603 
The `read` variable is in number of samples, while the offset must be in
bytes.

PR #4045 <#4045>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented May 31, 2023

Wow, good catch 👍

I rebased on dev branch, edited the commit message and merged: b2d8603

Out of curiosity, did you find the problem by just reading the code, or because you noticed abnormally audible audio glitches on underflow?

@rom1v rom1v closed this May 31, 2023
@shuax
Copy link
Contributor Author

shuax commented May 31, 2023

I tried to apply the volume using SDL_MixAudioFormat, and the sound was terrible, and I realized that read is not bytes, and then I found this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuax @rom1v